feat(outbox): produce outbox proofs by victor-dumitrescu · Pull Request #808 · tezos/riscv-pvm

victor-dumitrescu · 2026-02-11T09:16:52Z

What

The outbox can now produce a proof for an outbox message. A proof contains the message metadata and a Merkle proof which ties the inclusion of the given message in the outbox with a particular state hash.

Why

The outbox needs to support inclusion proofs for messages.

How

The OutboxProof type is introduced, along with Output and OutputInfo, which model Tezos protocol types.

Outbox proofs employ the same proof production mechanism used for fraud proofs. The difference is that the proven state transition is not one step of the PVM but a successful read of the given message from the outbox. The outbox is thus also expanded with the ability to read a single message.

Manually Testing

make all

In particular, the test_outbox_proofs_dummy_kernel test.

Regressions

A regression for an outbox proof for the first message of the last level of the dummy kernel is checked in.

Tasks for the Author

Link all Linear issues related to this MR using magic words (e.g. part of, relates to, closes).
Eliminate dead code and other spurious artefacts introduced in your changes.
Document new public functions, methods and types.
Make sure the documentation for updated functions, methods, and types is correct.
Add tests for bugs that have been fixed.
Explain changes to regression test captures when applicable.
Write commit messages in agreement with our guidelines.
Self-review your changes to ensure they are high-quality.
Complete all of the above before assigning this MR to reviewers.

codecov · 2026-02-11T09:31:53Z

Codecov Report

❌ Patch coverage is 95.30792% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.12%. Comparing base (80bfe8b) to head (f0c9b7b).

Files with missing lines	Patch %	Lines
src/riscv/lib/src/pvm/node_pvm.rs	0.00%	10 Missing ⚠️
src/riscv/lib/src/pvm/outbox.rs	98.68%	3 Missing and 1 partial ⚠️
src/riscv/lib/src/pvm/common.rs	88.88%	0 Missing and 1 partial ⚠️
src/riscv/lib/src/stepper/pvm.rs	94.11%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #808      +/-   ##
==========================================
+ Coverage   91.08%   91.12%   +0.03%     
==========================================
  Files         111      111              
  Lines       20964    21285     +321     
  Branches    20964    21285     +321     
==========================================
+ Hits        19096    19396     +300     
- Misses       1491     1510      +19     
- Partials      377      379       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2026-02-11T10:50:13Z

Benchmark results for revision 447c8e4:

Metric	Duration	TPS
Mean	1.522392966s	26.276
Worst	1.5470546s	25.856
Best	1.501283435s	26.644
Standard Deviation	±10.524011ms	±0.181

Full results

Run	Transfers	Duration	TPS
1	40	1.5470546s	25.856
2	40	1.519383365s	26.326
3	40	1.523412593s	26.257
4	40	1.526256451s	26.208
5	40	1.525619466s	26.219
6	40	1.522931726s	26.265
7	40	1.524953239s	26.230
8	40	1.545219464s	25.886
9	40	1.505672518s	26.566
10	40	1.517070447s	26.367
11	40	1.529345649s	26.155
12	40	1.528842934s	26.164
13	40	1.521224837s	26.295
14	40	1.514406221s	26.413
15	40	1.524819372s	26.233
16	40	1.512844931s	26.440
17	40	1.521002984s	26.298
18	40	1.519199421s	26.330
19	40	1.501283435s	26.644
20	40	1.517315676s	26.362

Compare the results above with those for the default branch.

emturner · 2026-02-11T11:42:04Z

Mean 1.543554521s 25.915

There seems to be a performance drop, perhaps?

src/riscv/lib/src/pvm/outbox.rs

emturner

overall LGTM

src/riscv/lib/src/pvm/common.rs

src/riscv/lib/src/pvm/outbox.rs

thomasathorne

Generally looks great!

Have a few questions about the different error cases and how they are currently tested (or not tested). I may have misunderstood something as some of the errors output in the tests aren't what I expected! 😅 At any rate, the different cases could be clarified a bit.

src/riscv/lib/src/pvm/outbox.rs

victor-dumitrescu · 2026-02-13T09:23:11Z

Mean 1.543554521s 25.915

There seems to be a performance drop, perhaps?

This PR now also contains a small PVM state restructuring which @emturner discovered offsets the slight dip in performance.

victor-dumitrescu · 2026-02-16T08:36:25Z

Ok, I've understood the different error cases now---sorry for my confusion earlier.

I still think if you want to make it really clear what is being tested in each case, adding a few more cases to the OutboxProofError enum would help. Unless I am missing something I think there are still two cases that aren't tested: the case where the outbox is uninitialised and the case where we try to read from a level that doesn't exist yet.

I've added tests for these cases here.

Splitting LevelNotFound into three cases (OutboxUninitialised, LevelTooOld and LevelNotReachedYet) would clarify this.

But this is more a stylistic choice than anything else, happy for you to resolve this comment if you want.

I'd rather not overcomplicate this error type. As for clarity of the code, I think each instance of raising LevelNotFound is now documented with the cause.

src/riscv/lib/src/pvm/common.rs

src/riscv/lib/src/pvm/outbox.rs

src/riscv/lib/src/pvm/common.rs

Co-authored-by: Emma Turner <[email protected]>

codecov · 2026-02-17T15:02:52Z

Codecov Report

❌ Patch coverage is 95.30792% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.12%. Comparing base (80bfe8b) to head (f0c9b7b).
⚠️ Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
src/riscv/lib/src/pvm/node_pvm.rs	0.00%	10 Missing ⚠️
src/riscv/lib/src/pvm/outbox.rs	98.68%	3 Missing and 1 partial ⚠️
src/riscv/lib/src/pvm/common.rs	88.88%	0 Missing and 1 partial ⚠️
src/riscv/lib/src/stepper/pvm.rs	94.11%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #808      +/-   ##
==========================================
+ Coverage   91.08%   91.12%   +0.03%     
==========================================
  Files         111      111              
  Lines       20964    21285     +321     
  Branches    20964    21285     +321     
==========================================
+ Hits        19096    19396     +300     
- Misses       1491     1510      +19     
- Partials      377      379       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

victor-dumitrescu force-pushed the vdum/rv-877 branch 2 times, most recently from 76fdfcc to 0886566 Compare February 11, 2026 10:32

victor-dumitrescu marked this pull request as ready for review February 11, 2026 10:47

victor-dumitrescu requested review from NSant215, emturner, jobjo, kurtisc, thomasathorne, vapourismo and zcabter as code owners February 11, 2026 10:47

emturner reviewed Feb 11, 2026

View reviewed changes

src/riscv/lib/src/pvm/outbox.rs Outdated Show resolved Hide resolved

victor-dumitrescu mentioned this pull request Feb 11, 2026

feat: support read messages from outbox level #793

Merged

9 tasks

victor-dumitrescu force-pushed the vdum/rv-877 branch from 0886566 to ca6fd05 Compare February 11, 2026 14:38

victor-dumitrescu requested a review from emturner February 11, 2026 14:44

victor-dumitrescu force-pushed the vdum/rv-877 branch 2 times, most recently from ec9b624 to fd14151 Compare February 12, 2026 08:18

emturner reviewed Feb 12, 2026

View reviewed changes

src/riscv/lib/src/pvm/common.rs Outdated Show resolved Hide resolved

src/riscv/lib/src/pvm/outbox.rs Outdated Show resolved Hide resolved

victor-dumitrescu force-pushed the vdum/rv-877 branch 4 times, most recently from 592faa4 to 01886c1 Compare February 12, 2026 14:07

victor-dumitrescu requested a review from emturner February 12, 2026 14:13

thomasathorne requested changes Feb 12, 2026

View reviewed changes

src/riscv/lib/src/pvm/outbox.rs Outdated Show resolved Hide resolved

src/riscv/lib/src/pvm/outbox.rs Outdated Show resolved Hide resolved

src/riscv/lib/src/pvm/outbox.rs Outdated Show resolved Hide resolved

src/riscv/lib/src/pvm/outbox.rs Show resolved Hide resolved

victor-dumitrescu force-pushed the vdum/rv-877 branch 2 times, most recently from fec1f02 to ec13689 Compare February 13, 2026 09:16

victor-dumitrescu requested a review from thomasathorne February 13, 2026 09:21

victor-dumitrescu force-pushed the vdum/rv-877 branch from 36a0127 to e6be7b8 Compare February 16, 2026 08:34

victor-dumitrescu requested review from thomasathorne and zcabter February 16, 2026 08:36

victor-dumitrescu force-pushed the vdum/rv-877 branch 3 times, most recently from 6f3a7c0 to 024a3f9 Compare February 16, 2026 10:35

emturner approved these changes Feb 16, 2026

View reviewed changes

victor-dumitrescu force-pushed the vdum/rv-877 branch from 024a3f9 to 5f8cef3 Compare February 16, 2026 10:46

vapourismo requested changes Feb 16, 2026

View reviewed changes

src/riscv/lib/src/pvm/common.rs Outdated Show resolved Hide resolved

src/riscv/lib/src/pvm/outbox.rs Outdated Show resolved Hide resolved

src/riscv/lib/src/pvm/outbox.rs Outdated Show resolved Hide resolved

victor-dumitrescu force-pushed the vdum/rv-877 branch from 5f8cef3 to 183497e Compare February 16, 2026 11:07

victor-dumitrescu requested a review from vapourismo February 16, 2026 11:10

thomasathorne reviewed Feb 16, 2026

View reviewed changes

src/riscv/lib/src/pvm/outbox.rs Outdated Show resolved Hide resolved

victor-dumitrescu force-pushed the vdum/rv-877 branch from 183497e to 5e06f46 Compare February 16, 2026 12:40

vapourismo requested changes Feb 16, 2026

View reviewed changes

src/riscv/lib/src/pvm/common.rs Outdated Show resolved Hide resolved

victor-dumitrescu requested a review from vapourismo February 16, 2026 14:06

vapourismo requested changes Feb 16, 2026

View reviewed changes

src/riscv/lib/src/pvm/common.rs Outdated Show resolved Hide resolved

victor-dumitrescu requested a review from vapourismo February 16, 2026 14:59

victor-dumitrescu force-pushed the vdum/rv-877 branch from 5e06f46 to 87cdf7a Compare February 17, 2026 09:07

victor-dumitrescu and others added 4 commits February 17, 2026 14:41

perf: restructure Pvm state

ffee91e

Co-authored-by: Emma Turner <[email protected]>

feat(outbox): support reading a message from the outbox

3308a09

feat(outbox): produce outbox proofs

1347547

test(outbox): regression tests for outbox proofs

f0c9b7b

victor-dumitrescu force-pushed the vdum/rv-877 branch from 87cdf7a to f0c9b7b Compare February 17, 2026 14:12

vapourismo approved these changes Feb 17, 2026

View reviewed changes

victor-dumitrescu added this pull request to the merge queue Feb 17, 2026

Merged via the queue into main with commit 13590c2 Feb 17, 2026
8 checks passed

victor-dumitrescu deleted the vdum/rv-877 branch February 17, 2026 15:02

Conversation

victor-dumitrescu commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Why

How

Manually Testing

Regressions

Tasks for the Author

Uh oh!

codecov bot commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

emturner commented Feb 11, 2026

Uh oh!

Uh oh!

emturner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

thomasathorne left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

victor-dumitrescu commented Feb 13, 2026

Uh oh!

victor-dumitrescu commented Feb 16, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Feb 17, 2026

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

victor-dumitrescu commented Feb 11, 2026 •

edited

Loading

codecov bot commented Feb 11, 2026 •

edited

Loading

github-actions bot commented Feb 11, 2026 •

edited

Loading